Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: NFT find is broken #5035

Merged
merged 14 commits into from
Sep 30, 2019
Merged

R4R: NFT find is broken #5035

merged 14 commits into from
Sep 30, 2019

Conversation

okwme
Copy link
Contributor

@okwme okwme commented Sep 11, 2019 •
edited by fedekunze
Loading

fixes #5034

Added tests to show find is broken.

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze
Copy link
Collaborator

sadly we can't merge something that breaks the CI, can you fix find too, please?

@okwme okwme changed the title NFT find is broken WIP: NFT find is broken Sep 11, 2019
@fedekunze fedekunze added the WIP label Sep 11, 2019
@okwme
Copy link
Contributor Author

okwme commented Sep 11, 2019

sorry @fedekunze meant for this to be WIP. Sounds like DGaming might be able to help out here

okwme
okwme commented Sep 18, 2019
View reviewed changes
x/nft/internal/types/utils.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 18, 2019 •
edited
Loading

Codecov Report

Merging #5035 into master will decrease coverage by 0.05%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##           master    #5035      +/-   ##
==========================================
- Coverage   54.94%   54.89%   -0.06%     
==========================================
  Files         295      296       +1     
  Lines       18235    18232       -3     
==========================================
- Hits        10020    10009      -11     
- Misses       7478     7486       +8     
  Partials      737      737

golangcibot
golangcibot reviewed Sep 18, 2019
View reviewed changes
x/nft/internal/types/owners.go Outdated Show resolved Hide resolved
x/nft/internal/types/owners.go Outdated Show resolved Hide resolved
x/nft/internal/types/owners.go Outdated Show resolved Hide resolved
x/nft/internal/types/owners.go Outdated Show resolved Hide resolved
@okwme okwme changed the title WIP: NFT find is broken R4R: NFT find is broken Sep 18, 2019
@okwme okwme added T:Bug R4R and removed WIP labels Sep 19, 2019
fedekunze
fedekunze suggested changes Sep 25, 2019
View reviewed changes
x/nft/internal/types/nft.go Outdated Show resolved Hide resolved
x/nft/internal/types/collection.go Outdated Show resolved Hide resolved
x/nft/internal/types/collection.go Outdated Show resolved Hide resolved
x/nft/internal/types/collection.go Outdated Show resolved Hide resolved
x/nft/internal/types/nft.go Outdated Show resolved Hide resolved
@fedekunze fedekunze merged commit 6db7398 into master Sep 30, 2019
@fedekunze fedekunze deleted the nft-find-fix branch September 30, 2019 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golangcibot golangcibot golangcibot left review comments

@fedekunze fedekunze fedekunze approved these changes

@alessio alessio Awaiting requested review from alessio

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
T:Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NFT Find is Broken
3 participants
@okwme @fedekunze @golangcibot